formal_review_process.htm 11 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272
  1. <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
  2. <html>
  3. <head>
  4. <meta name="generator" content=
  5. "Microsoft FrontPage 5.0">
  6. <meta http-equiv="Content-Type" content=
  7. "text/html; charset=windows-1252">
  8. <meta name="GENERATOR" content="Microsoft FrontPage 5.0">
  9. <meta name="ProgId" content="FrontPage.Editor.Document">
  10. <title>Boost Formal Review Process</title>
  11. </head>
  12. <body bgcolor="#FFFFFF" text="#000000">
  13. <table border="1" bgcolor="#007F7F" cellpadding="2">
  14. <tr>
  15. <td bgcolor="#FFFFFF"><img src="../boost.png" alt=
  16. "boost.png (6897 bytes)" width="277" height="86"></td>
  17. <td><a href="../index.htm"><font face="Arial" color=
  18. "#FFFFFF"><big>Home</big></font></a></td>
  19. <td><a href="../libs/libraries.htm"><font face="Arial" color=
  20. "#FFFFFF"><big>Libraries</big></font></a></td>
  21. <td><a href="../people/people.htm"><font face="Arial" color=
  22. "#FFFFFF"><big>People</big></font></a></td>
  23. <td><a href="faq.htm"><font face="Arial" color=
  24. "#FFFFFF"><big>FAQ</big></font></a></td>
  25. <td><a href="index.htm"><font face="Arial" color=
  26. "#FFFFFF"><big>More</big></font></a></td>
  27. </tr>
  28. </table>
  29. <h1>Boost Formal Review Process</h1>
  30. <p><a href="#Introduction">Introduction</a><br>
  31. <a href="#Comments">What to include in Review Comments</a><br>
  32. <a href="#Results">Results</a><br>
  33. <a href="#Review_Manager">Notes for Review Managers</a><br>
  34. <a href="#Submitters">Notes for Library Submitters</a><br>
  35. <a href="#Wizard">Review Wizard</a><br>
  36. <a href="#Fast-Track">Fast Track Reviews</a></p>
  37. <h2><a name="Introduction">Introduction</a></h2>
  38. <p>Proposed libraries are accepted into Boost only after undergoing a
  39. formal review, where Boost mailing list members comment on their
  40. evaluation of the library.</p>
  41. <p>The final "accept" or "reject" decision is made by the <a href=
  42. "#Review_Manager">Review Manager</a>, based on the review comments
  43. received from boost mailing list members.</p>
  44. <p>Boost mailing list members are encouraged to submit Formal Review
  45. comments:</p>
  46. <blockquote>
  47. <ul>
  48. <li>Publicly on the mailing list.</li>
  49. <li>Privately to the Review Manager.</li>
  50. </ul>
  51. </blockquote>
  52. <p>Private comments to a library submitter may be helpful to her or him,
  53. but won't help the Review Manager reach a decision, so the other forms
  54. are preferred.</p>
  55. <h2>What to include in Review <a name="Comments">Comments</a></h2>
  56. <p>Your comments may be brief or lengthy, but basically the Review
  57. Manager needs your evaluation of the library.&nbsp; If you identify
  58. problems along the way, please note if they are minor, serious, or
  59. showstoppers.</p>
  60. <p>Here are some questions you might want to answer in your review:</p>
  61. <ul>
  62. <li>What is your evaluation of the design?<br>
  63. </li>
  64. <li>What is your evaluation of the implementation?<br>
  65. </li>
  66. <li>What is your evaluation of the documentation?<br>
  67. </li>
  68. <li>What is your evaluation of the potential usefulness of the
  69. library?<br>
  70. </li>
  71. <li>Did you try to use the library?&nbsp; With what compiler?&nbsp; Did
  72. you have any problems?<br>
  73. </li>
  74. <li>How much effort did you put into your evaluation? A glance? A quick
  75. reading? In-depth study?<br>
  76. </li>
  77. <li>Are you knowledgeable about the problem domain?</li>
  78. </ul>
  79. <p>And finally, every review should answer this question:<br>
  80. </p>
  81. <ul>
  82. <li>Do you think the library should be accepted as a Boost
  83. library?&nbsp; Be sure to say this explicitly so that your other
  84. comments don't obscure your overall opinion.</li>
  85. </ul>
  86. <h2><a name="Results">Results</a></h2>
  87. <p>At the conclusion of the comment period, the Review Manager will post
  88. a message to the mailing list saying if the library has been accepted or
  89. rejected.&nbsp; A rationale is also helpful, but its extent is up to the
  90. Review Manager. If there are suggestions, or conditions that must be met
  91. before final inclusion, they should be stated.</p>
  92. <h2>Notes for <a name="Review_Manager">Review Manager</a>s</h2>
  93. <p>Before a library can be scheduled for formal review, an active boost
  94. member not connected with the library submission must volunteer to be the
  95. "Review Manager" for the library.</p>
  96. <p>The Review Manager:</p>
  97. <ul>
  98. <li>Checks the submission to make sure it really is complete enough to
  99. warrant formal review.&nbsp; See the <a href="lib_guide.htm">Boost
  100. Library Requirements and Guidelines</a>.&nbsp; If necessary, work with
  101. the submitter to verify the code compiles and runs correctly on several
  102. compilers and platforms.</li>
  103. <li>Finalizes the schedule with the <a href="#Wizard">Review Wizard</a>
  104. and the submitter .</li>
  105. <li>
  106. Posts a notice of the review schedule on both the regular <b><a href=
  107. "mailto:boost@lists.boost.org">boost mailing list</a></b> and the
  108. <b><a href="mailto:boost-announce@lists.boost.org">boost-announce</a>
  109. mailing list</b>.
  110. <ul>
  111. <li>The notice should include a brief description of the library
  112. and what it does, to let readers know if the library is one they
  113. are interested in reviewing.</li>
  114. <li>If the library is known to fail with certain compilers, please
  115. mention them in the review notice so reviewers with those compilers
  116. won't waste time diagnosing known problems.</li>
  117. </ul>
  118. </li>
  119. <li>Inspects the Boost <a href="../libs/libraries.htm">library
  120. catalogue</a> for libraries which may interact with the new submission.
  121. These potential interactions should be pointed out in the review
  122. announcement, and the author(s) of these libraries should be privately
  123. notified and urged to participate in the review.</li>
  124. <li>Urges people to do reviews if they aren't forthcoming.</li>
  125. <li>Follows review discussions regarding the library, moderating or
  126. answering questions as needed.</li>
  127. <li>Decides if there is consensus to accept the library, and if there
  128. are any conditions attached.</li>
  129. <li>Posts a message on both the <b><a href=
  130. "mailto:boost@lists.boost.org">boost</a></b> and <b><a href=
  131. "mailto:boost-announce@lists.boost.org">boost-announce</a></b> lists
  132. informing members of the <a href="#Results">review results</a>.</li>
  133. </ul>
  134. <p>In other words, it is the Review Manager's responsibility to make sure
  135. the review process works smoothly.</p>
  136. <h2>Notes for Library <a name="Submitters">Submitters</a></h2>
  137. <p>See <a href="submission_process.htm">Submission Process</a> for a
  138. description of the steps a library developer goes through to get a
  139. library accepted by Boost.</p>
  140. <p>A proposed library should remain stable during the review period; it
  141. will just confuse and irritate reviewers if there are numerous
  142. changes.&nbsp; It is, however, useful to upload fixes for serious bugs
  143. right away, particularly those which prevent reviewers from fully
  144. evaluating the library.&nbsp; Post a notice of such fixes on the mailing
  145. list.</p>
  146. <p>Library improvements suggested by reviewers should normally be held
  147. until after the completion of review period.&nbsp; If the suggested
  148. changes might affect reviewer's judgments,&nbsp;post a notice of the
  149. pending change on the mailing list.</p>
  150. <h2>Review <a name="Wizard">Wizard</a></h2>
  151. <p>The Review Wizard coordinates the formal review schedule:</p>
  152. <ul>
  153. <li>Maintains a list of review manager volunteers, in the form of a
  154. queue, so that volunteers who least recently managed reviews become the
  155. prime candidates for upcoming reviews.</li>
  156. <li>When a formal review is requested for a library:</li>
  157. <li style="list-style: none">
  158. &nbsp;<ul>
  159. <li>Assign a review manager and suggests a schedule, after checking
  160. (via private email) availability of the volunteers at the top of
  161. review manager queue.</li>
  162. <li>Finalize the schedule, once the review manager verifies the
  163. library is actually ready for review.</li>
  164. <li>Resolve schedule slips or other issues with review managers and
  165. submitters.</li>
  166. </ul>
  167. </li>
  168. <li>Maintains a schedule of both past and pending reviews, in the form
  169. of the <a href="formal_review_schedule.html">Review Schedule</a> web
  170. page.</li>
  171. <li>Resolves questions from review managers and library submitters, who
  172. sometimes want a third opinion on questions such as "Should we extend
  173. the review period because ...?"</li>
  174. <li>Monitors the general review process, and makes minor adjustments as
  175. needed, or queries the list about possible major adjustments.</li>
  176. </ul>
  177. The role of Boost Review Wizard is currently played by <a href=
  178. "mailto:reportbase@yahoo.com">Tom Brinkman</a>.<h2><a name="Fast-Track">Fast Track Reviews</a></h2>
  179. <p>To qualify for fast track review:</p>
  180. <ul>
  181. <li>The component must be small.</li>
  182. <li>The technique must be already in use in Boost libraries and the new
  183. component provides a common implementation.</li>
  184. <li>A full Boost-conformant implementation is available in the sandbox.</li>
  185. <li>The Review Wizard determines that the proposal qualifies for fast
  186. track review.</li>
  187. </ul>
  188. <p>Procedure:</p>
  189. <ul>
  190. <li>The Boost Review Wizard posts a review announcement to the main Boost
  191. developer's list. The review period will normally last for 5 days. No two
  192. fast track reviews will run in parallel. Fast track reviews may run during
  193. full reviews, though generally this is to be avoided.</li>
  194. <li>After the review period ends, the submitter will post a review summary
  195. containing proposed changes to the reviewed implementation.</li>
  196. <li>The Review Wizard will accept or reject the proposed library and
  197. proposed changes.</li>
  198. <li>After applying the proposed changes, the component is checked into CVS
  199. like any other library.<br>
  200. &nbsp;</li>
  201. </ul>
  202. <hr>
  203. <p>Revised
  204. <!--webbot bot="Timestamp" s-type="EDITED" s-format="%d %B, %Y" startspan -->15 October, 2003<!--webbot bot="Timestamp" endspan i-checksum="38556" --></p>
  205. <p>© Copyright Beman Dawes 2000</p>
  206. <p> Use, modification, and distribution are subject to the Boost Software
  207. License, Version 1.0. (See accompanying file <a href="../LICENSE_1_0.txt">
  208. LICENSE_1_0.txt</a> or copy at <a href="http://www.boost.org/LICENSE_1_0.txt">
  209. www.boost.org/LICENSE_1_0.txt</a>)</p>
  210. </body>
  211. </html>
粤ICP备19079148号