Просмотр исходного кода

WebGPUBackend: Remove redundant dispose handlers. (#31603)

* WebGPUBackend: Remove redundant dispose handlers.

* Textures: Delete backend data in `onDispose()`.
Michael Herzog 9 месяцев назад
Родитель
Сommit
fda27bb22a
2 измененных файлов с 2 добавлено и 18 удалено
  1. 1 0
      src/renderers/common/Textures.js
  2. 1 18
      src/renderers/webgpu/WebGPUBackend.js

+ 1 - 0
src/renderers/common/Textures.js

@@ -179,6 +179,7 @@ class Textures extends DataMap {
 				}
 				}
 
 
 				this.delete( renderTarget );
 				this.delete( renderTarget );
+				this.backend.delete( renderTarget );
 
 
 			};
 			};
 
 

+ 1 - 18
src/renderers/webgpu/WebGPUBackend.js

@@ -390,7 +390,6 @@ class WebGPUBackend extends Backend {
 		if ( descriptors === undefined ||
 		if ( descriptors === undefined ||
 			renderTargetData.width !== renderTarget.width ||
 			renderTargetData.width !== renderTarget.width ||
 			renderTargetData.height !== renderTarget.height ||
 			renderTargetData.height !== renderTarget.height ||
-			renderTargetData.dimensions !== renderTarget.dimensions ||
 			renderTargetData.activeMipmapLevel !== renderContext.activeMipmapLevel ||
 			renderTargetData.activeMipmapLevel !== renderContext.activeMipmapLevel ||
 			renderTargetData.activeCubeFace !== renderContext.activeCubeFace ||
 			renderTargetData.activeCubeFace !== renderContext.activeCubeFace ||
 			renderTargetData.samples !== renderTarget.samples
 			renderTargetData.samples !== renderTarget.samples
@@ -400,21 +399,6 @@ class WebGPUBackend extends Backend {
 
 
 			renderTargetData.descriptors = descriptors;
 			renderTargetData.descriptors = descriptors;
 
 
-			// dispose
-
-			const onDispose = () => {
-
-				renderTarget.removeEventListener( 'dispose', onDispose );
-				this.delete( renderTarget );
-
-			};
-
-			if ( renderTarget.hasEventListener( 'dispose', onDispose ) === false ) {
-
-				renderTarget.addEventListener( 'dispose', onDispose );
-
-			}
-
 		}
 		}
 
 
 		const cacheKey = renderContext.getCacheKey();
 		const cacheKey = renderContext.getCacheKey();
@@ -534,7 +518,6 @@ class WebGPUBackend extends Backend {
 			renderTargetData.samples = renderTarget.samples;
 			renderTargetData.samples = renderTarget.samples;
 			renderTargetData.activeMipmapLevel = renderContext.activeMipmapLevel;
 			renderTargetData.activeMipmapLevel = renderContext.activeMipmapLevel;
 			renderTargetData.activeCubeFace = renderContext.activeCubeFace;
 			renderTargetData.activeCubeFace = renderContext.activeCubeFace;
-			renderTargetData.dimensions = renderTarget.dimensions;
 
 
 		}
 		}
 
 
@@ -2230,7 +2213,7 @@ class WebGPUBackend extends Backend {
 	}
 	}
 
 
 	/**
 	/**
-	 * Checks if the given feature is supported  by the backend.
+	 * Checks if the given feature is supported by the backend.
 	 *
 	 *
 	 * @param {string} name - The feature's name.
 	 * @param {string} name - The feature's name.
 	 * @return {boolean} Whether the feature is supported or not.
 	 * @return {boolean} Whether the feature is supported or not.

粤ICP备19079148号