yaoyao/tests/server/taskCoordinator.test.ts

// @vitest-environment node
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { mkdtempSync, rmSync } from 'node:fs'
import { tmpdir } from 'node:os'
import { join } from 'node:path'
import { randomUUID } from 'node:crypto'
import { WorkspaceStore } from '../../src/server/workspaceStore'
import { WorkspaceRuntime } from '../../src/server/workspaceRuntime'
import { UploadStore } from '../../src/server/uploads'
import type { WorkspaceNodes } from '../../src/server/workspaceGateway'
import type { WorkspaceAgent, WorkspaceConversation, WorkspaceRun } from '../../src/shared/workspace'
import type { AgentGoal, AgentAssignment, TaskDelivery } from '../../src/shared/agentTasks'

let home: string, store: WorkspaceStore, runtime: WorkspaceRuntime, uploads: UploadStore
let lead: WorkspaceAgent, worker: WorkspaceAgent, second: WorkspaceAgent, team: WorkspaceConversation, goal: AgentGoal
let active: boolean, authorizationVersion: number
const owner = 'task-owner', sourceDevice=randomUUID()
beforeEach(() => {
  home=mkdtempSync(join(tmpdir(),'yaoyao-goal-tests-'));store=new WorkspaceStore(home);uploads=new UploadStore(home);active=true;authorizationVersion=1
  runtime=new WorkspaceRuntime(store,{requireSource:()=>{}} as unknown as WorkspaceNodes,uploads,()=>active,()=>authorizationVersion)
  vi.spyOn(runtime,'wake').mockImplementation(()=>{})
  lead=store.createAgent(owner,{name:'老板',profile:'default',canManageTeam:true})
  worker=store.createAgent(owner,{name:'研究',profile:'default'})
  second=store.createAgent(owner,{name:'编辑',profile:'default'})
  team=store.createGroup(owner,{name:'工作团队',memberIds:[lead.id,worker.id,second.id],administratorId:lead.id})
  const source=store.list<WorkspaceConversation>(owner,'conversation').find(c=>c.kind==='direct'&&c.memberIds[0]===lead.id)!
  const origin=runtime.send(owner,source.id,{requestId:randomUUID(),content:'完成调研报告',deviceHost:sourceDevice})
  origin.status='complete';store.saveRun(owner,origin)
  goal=runtime.tasks.begin(owner,store.tasks(owner,team.id)[0]!,lead,'完成调研报告',{conversationId:source.id,runId:origin.id,agentId:lead.id},['内容可核对'])
})
afterEach(()=>{runtime.close();uploads.close();store.close();rmSync(home,{recursive:true,force:true})})

function assign(name:string,agent=worker,dependsOn:string[]=[]) {
  return runtime.tasks.createAssignment(owner,lead.id,{requestId:randomUUID(),goalId:goal.id,agentId:agent.id,title:name,brief:'提交实际结果',acceptanceCriteria:['内容可核对'],dependsOn})
}
function settle(runId:string,status:WorkspaceRun['status']='complete',text='有依据的执行结果') {
  const run=store.require<WorkspaceRun>(owner,'run',runId)
  if(text)store.saveMessage(owner,{id:randomUUID(),conversationId:run.conversationId,conversationTaskId:run.conversationTaskId,
    seq:0,role:'assistant',agentId:run.targetAgentId||lead.id,content:text,reasoning:'',status:status==='complete'?'complete':'failed',runId,createdAt:Date.now(),attachments:[],tools:[]})
  run.status=status;store.saveRun(owner,run)
}
const assignment=(id:string)=>store.require<AgentAssignment>(owner,'assignment',id)

describe('durable team task coordination',()=>{
  it('keeps chat lightweight and starts one explicit goal in the existing topic', () => {
    const conversation = store.createGroup(owner, {name:'日常群聊',memberIds:[lead.id,worker.id],administratorId:lead.id,mode:'free',autoReplyIds:[worker.id]})
    const task = store.tasks(owner, conversation.id)[0]!
    const chat = runtime.send(owner, conversation.id, {requestId:randomUUID(),taskId:task.id,content:'讨论一下方案'})
    expect(store.get(owner,'goal',task.id)).toBeUndefined()
    expect(runtime.tasks.assignments(owner,task.id)).toEqual([])
    settle(chat.id)
    const input = {requestId:randomUUID(),taskId:task.id,content:'完成方案并交付报告',mode:'goal'}
    const run = runtime.send(owner,conversation.id,input)
    expect(runtime.send(owner,conversation.id,input).id).toBe(run.id)
    expect(store.tasks(owner,conversation.id)).toHaveLength(1)
    expect(store.require<AgentGoal>(owner,'goal',task.id)).toMatchObject({objective:input.content,coordinatorId:lead.id})
    expect(run).toMatchObject({goalId:task.id,targetAgentId:lead.id})
    expect(store.list<{runId:string;agentId:string}>(owner,'turn').filter(w=>w.runId===run.id).map(w=>w.agentId)).toEqual([lead.id])
    expect(runtime.tasks.assignments(owner,task.id)).toEqual([])
    const review = runtime.dispatch(owner,conversation.id,{requestId:randomUUID(),taskId:task.id,content:'复核进展'}, {agentId:lead.id,kind:'task_review'})
    expect(store.list<{runId:string;agentId:string}>(owner,'turn').filter(w=>w.runId===review.id).map(w=>w.agentId)).toEqual([lead.id])
    settle(review.id)
    expect(runtime.tasks.finish(owner,lead.id,{requestId:randomUUID(),goalId:task.id,status:'complete',result:'交付完整报告',checks:[{criterion:0,passed:true,evidence:'报告已对照请求核验'}]},run.id).status).toBe('complete')
  })
  it('rejects delivery without a valid coordinator or during existing chat work without leaving a goal', () => {
    const conversation = store.createGroup(owner,{name:'讨论群',memberIds:[lead.id,worker.id],administratorId:worker.id})
    store.updateAgent(owner,worker.id,{archived:true})
    const task = store.tasks(owner,conversation.id)[0]!
    const input = {requestId:randomUUID(),taskId:task.id,mode:'goal',content:'完成报告'}
    expect(()=>runtime.send(owner,conversation.id,input)).toThrow('负责人需要是本机上未归档的 Bot')
    store.updateAgent(owner,worker.id,{archived:false})
    expect(store.get(owner,'goal',task.id)).toBeUndefined()
    expect(store.messages(owner,conversation.id)).toEqual([])
    store.updateConversation(owner,conversation.id,{administratorId:lead.id})
    runtime.send(owner,conversation.id,{requestId:randomUUID(),taskId:task.id,content:'先讨论'})
    expect(()=>runtime.send(owner,conversation.id,input)).toThrow('等待当前回复')
    expect(store.get(owner,'goal',task.id)).toBeUndefined()
  })
  it('edits criteria with concurrency protection and refuses completion against superseded criteria', () => {
    const input = {requestId:randomUUID(),expectedRevision:1,acceptanceCriteria:['报告应比较三种方案']}
    const edited = runtime.tasks.updateCriteria(owner,goal.id,input)
    expect(edited.acceptanceRevision).toBe(2)
    expect(runtime.tasks.updateCriteria(owner,goal.id,input)).toEqual(edited)
    expect(()=>runtime.tasks.updateCriteria(owner,goal.id,{...input,requestId:randomUUID(),acceptanceCriteria:['覆盖用户的新要求']})).toThrow('已更新')
    const finish = {requestId:randomUUID(),goalId:goal.id,status:'complete',result:'完成',checks:[{criterion:0,passed:true,evidence:'原有验收依据'}]}
    expect(()=>runtime.tasks.finish(owner,lead.id,finish)).toThrow('最新要求')
    expect(()=>runtime.tasks.updateCriteria('other',goal.id,{...input,requestId:randomUUID()})).toThrow()
    expect(runtime.tasks.finish(owner,lead.id,{...finish,acceptanceRevision:2,checks:[{criterion:0,passed:true,evidence:'报告包含三种方案及逐项比较'}]}).status).toBe('complete')
    expect(()=>runtime.tasks.updateCriteria(owner,goal.id,{...input,requestId:randomUUID(),expectedRevision:2})).toThrow('进行中的目标')
  })
  it('wakes an idle coordinator once for newly edited criteria without creating assignments', async () => {
    const run = runtime.dispatch(owner,team.id,{requestId:randomUUID(),taskId:goal.id,content:'直接交付报告'}, {agentId:lead.id,kind:'task_review'})
    settle(run.id)
    await vi.waitFor(()=>expect(store.list<TaskDelivery>(owner,'task-delivery')).toHaveLength(1))
    const firstDelivery = store.list<TaskDelivery>(owner,'task-delivery')[0]!
    settle(firstDelivery.runId!)
    runtime.tasks.updateCriteria(owner,goal.id,{requestId:randomUUID(),expectedRevision:1,acceptanceCriteria:['增加三种方案的比较']})
    await vi.waitFor(()=>expect(store.list<TaskDelivery>(owner,'task-delivery')).toHaveLength(2))
    runtime.tasks.wake()
    await new Promise(resolve=>setTimeout(resolve,5))
    expect(store.list<TaskDelivery>(owner,'task-delivery')).toHaveLength(2)
    expect(runtime.tasks.assignments(owner,goal.id)).toEqual([])
  })
  it('runs dependencies only after review, returns a result to the original conversation once',async()=>{
    const a=assign('调研'),b=assign('撰写',second,[a.id])
    await vi.waitFor(()=>expect(assignment(a.id).status).toBe('running'))
    expect(assignment(b.id).status).toBe('pending')
    const run=store.require<WorkspaceRun>(owner,'run',assignment(a.id).runId!)
    expect(run).toMatchObject({targetAgentId:worker.id,assignmentId:a.id,triggerKind:'assignment',deviceHost:sourceDevice})
    settle(run.id)
    await vi.waitFor(()=>expect(assignment(a.id).status).toBe('review'))
    expect(assignment(b.id).status).toBe('pending')
    await vi.waitFor(()=>expect(store.list<TaskDelivery>(owner,'task-delivery')).toHaveLength(1))
    const delivered=store.list<TaskDelivery>(owner,'task-delivery')[0]!
    expect(delivered.targetConversationId).toBe(goal.origin.conversationId)
    expect(store.require<WorkspaceRun>(owner,'run',delivered.runId!).deviceHost).toBe(sourceDevice)
    expect(store.messages(owner,goal.origin.conversationId).at(-1)?.role).toBe('system')
    runtime.tasks.wake();await new Promise(resolve=>setTimeout(resolve,5))
    expect(store.list(owner,'task-delivery')).toHaveLength(1)
    runtime.tasks.reviewAssignment(owner,lead.id,{requestId:randomUUID(),assignmentId:a.id,decision:'accept',review:'来源和内容均已核对'})
    await vi.waitFor(()=>expect(assignment(b.id).status).toBe('running'))
    expect(()=>runtime.tasks.finish(owner,lead.id,{requestId:randomUUID(),goalId:goal.id,status:'complete',result:'报告完成'})).toThrow('未验收')
    settle(assignment(b.id).runId!)
    await vi.waitFor(()=>expect(assignment(b.id).status).toBe('review'))
    runtime.tasks.reviewAssignment(owner,lead.id,{requestId:randomUUID(),assignmentId:b.id,decision:'accept',review:'报告满足要求'})
    const ended=runtime.tasks.finish(owner,lead.id,{requestId:randomUUID(),goalId:goal.id,status:'complete',result:'报告已完成，已复核来源和内容',checks:[{criterion:0,passed:true,evidence:'已逐项核对调研和撰写结果'}]},delivered.runId)
    expect(ended.status).toBe('complete')
    settle(delivered.runId!,'complete','报告已完成，已复核来源和内容')
    await vi.waitFor(()=>expect(store.list<TaskDelivery>(owner,'task-delivery').filter(d=>d.kind==='terminal'&&d.status==='delivered')).toHaveLength(1))
    const terminal=store.list<TaskDelivery>(owner,'task-delivery').find(d=>d.kind==='terminal')!
    expect(terminal.runId).toBe(delivered.runId)
  })

  it('does not treat a failed execution as accepted and supports bounded, explicit rework',async()=>{
    const a=assign('调研')
    await vi.waitFor(()=>expect(assignment(a.id).runId).toBeTruthy())
    settle(assignment(a.id).runId!,'failed','检索失败')
    await vi.waitFor(()=>expect(assignment(a.id).status).toBe('failed'))
    expect(()=>runtime.tasks.reviewAssignment(owner,lead.id,{requestId:randomUUID(),assignmentId:a.id,decision:'accept',review:'忽略错误'})).toThrow('失败')
    const old=assignment(a.id).runId
    runtime.tasks.reviewAssignment(owner,lead.id,{requestId:randomUUID(),assignmentId:a.id,decision:'retry',review:'缩小检索范围后重试'})
    await vi.waitFor(()=>expect(assignment(a.id).runId).not.toBe(old))
    expect(assignment(a.id).attempt).toBe(2)
  })

  it('rejects cross-goal dependencies and another coordinator',()=>{
    expect(()=>assign('非法依赖',worker,[randomUUID()])).toThrow('依赖')
    expect(()=>runtime.tasks.createAssignment(owner,worker.id,{requestId:randomUUID(),goalId:goal.id,agentId:second.id,title:'越权',brief:'不应执行'})).toThrow('无权')
    expect(()=>runtime.tasks.finish('another',lead.id,{requestId:randomUUID(),goalId:goal.id,status:'complete',result:'伪造'})).toThrow()
  })

  it.each(['disabled','credentials','archived','restored','origin_stopped'])('never resurrects a stopped or revoked goal: %s',async reason=>{
    const a=assign('调研')
    await vi.waitFor(()=>expect(assignment(a.id).runId).toBeTruthy())
    if(reason==='disabled')active=false
    if(reason==='credentials')authorizationVersion++
    if(reason==='archived'||reason==='restored')store.updateAgent(owner,lead.id,{archived:true})
    if(reason==='restored')store.updateAgent(owner,lead.id,{archived:false})
    if(reason==='origin_stopped'){
      const source=store.require<WorkspaceRun>(owner,'run',goal.origin.runId);source.stopRequested=true;store.saveRun(owner,source)
    }
    settle(assignment(a.id).runId!)
    runtime.tasks.wake()
    await new Promise(resolve=>setTimeout(resolve,30))
    expect(store.list<TaskDelivery>(owner,'task-delivery').filter(d=>d.status==='delivered')).toEqual([])
  })
  it('resumes only from a new user instruction after previous execution is confirmed stopped',async()=>{
    const a=assign('调研')
    await vi.waitFor(()=>expect(assignment(a.id).runId).toBeTruthy())
    const old=assignment(a.id).runId!
    runtime.tasks.cancel(owner,goal.id)
    const source=runtime.send(owner,goal.origin.conversationId,{requestId:randomUUID(),content:'继续这个任务'})
    const origin={...goal.origin,runId:source.id}
    expect(()=>runtime.tasks.resume(owner,lead.id,{requestId:randomUUID(),goalId:goal.id},origin)).toThrow('旧执行')
    settle(old,'interrupted','')
    await vi.waitFor(()=>expect(store.get<AgentGoal>(owner,'goal',goal.id)?.status).toBe('cancelled'))
    const resumed=runtime.tasks.resume(owner,lead.id,{requestId:randomUUID(),goalId:goal.id},origin)
    expect(resumed.activation).toBe(2)
    expect(resumed.origin.runId).toBe(source.id)
    await vi.waitFor(()=>expect(assignment(a.id).runId).not.toBe(old))
    expect(assignment(a.id).attempt).toBe(2)
  })
  it('requires a result for every acceptance criterion',()=>{
    expect(()=>runtime.tasks.finish(owner,lead.id,{requestId:randomUUID(),goalId:goal.id,status:'complete',result:'完成'})).toThrow('逐项')
    expect(()=>runtime.tasks.finish(owner,lead.id,{requestId:randomUUID(),goalId:goal.id,status:'complete',result:'完成',checks:[{criterion:0,passed:false,evidence:'尚未核对'}]})).toThrow('逐项')
  })

  it('repairs a missed result dispatch without duplicating the durable source message',async()=>{
    const a=assign('调研')
    await vi.waitFor(()=>expect(assignment(a.id).runId).toBeTruthy())
    const dispatch=vi.spyOn(runtime,'dispatch')
    dispatch.mockImplementationOnce(()=>{throw new Error('simulate dispatch crash')})
    settle(assignment(a.id).runId!)
    await vi.waitFor(()=>expect(assignment(a.id).status).toBe('review'))
    runtime.tasks.wake()
    await vi.waitFor(()=>expect(store.list<TaskDelivery>(owner,'task-delivery').filter(d=>d.status==='delivered')).toHaveLength(1))
    const count=store.messages(owner,goal.origin.conversationId).length
    runtime.tasks.wake();await new Promise(resolve=>setTimeout(resolve,10))
    expect(store.messages(owner,goal.origin.conversationId)).toHaveLength(count)
  })
})

it('pins new assignments to the current message device instead of the old goal origin',async()=>{
 const deviceHost=randomUUID()
 for(const [index,source] of [deviceHost,undefined].entries()){
  const message=runtime.send(owner,goal.origin.conversationId,{requestId:randomUUID(),content:'按当前设备继续',deviceHost:source})
  message.status='complete';store.saveRun(owner,message)
  const child=runtime.tasks.createAssignment(owner,lead.id,{requestId:randomUUID(),goalId:goal.id,agentId:index===0?worker.id:second.id,title:'新子任务'+index,brief:'使用本机文件',acceptanceCriteria:[],dependsOn:[]},message.id)
  await vi.waitFor(()=>expect(assignment(child.id).runId).toBeTruthy())
  expect(store.require<WorkspaceRun>(owner,'run',assignment(child.id).runId!).deviceHost).toBe(source)
 }
 expect(store.require<WorkspaceRun>(owner,'run',goal.origin.runId).deviceHost).toBe(sourceDevice)
})