| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126 |
- import test from 'node:test';
- import assert from 'node:assert/strict';
- import { classifyOwnerMessageGate } from './owner_message_gate.js';
- function makeRecentlySent(ids = []) {
- const set = new Set(ids);
- return { has: (id) => set.has(id) };
- }
- function makeAllowlist(allowedChatIds) {
- if (allowedChatIds === '*') {
- return () => true;
- }
- const set = new Set(allowedChatIds);
- return (id) => set.has(id);
- }
- test('non-fromMe messages always pass through', () => {
- const decision = classifyOwnerMessageGate({
- fromMe: false,
- fromOwnerEnabled: true,
- recentlySent: makeRecentlySent(),
- allowlistMatches: makeAllowlist([]),
- messageId: 'M1',
- chatId: '6281234567890@s.whatsapp.net',
- });
- assert.deepEqual(decision, { action: 'pass' });
- });
- test('fromMe echo of our own /send is dropped', () => {
- const decision = classifyOwnerMessageGate({
- fromMe: true,
- fromOwnerEnabled: true,
- recentlySent: makeRecentlySent(['M-OWN-1']),
- allowlistMatches: makeAllowlist('*'),
- messageId: 'M-OWN-1',
- chatId: '6281234567890@s.whatsapp.net',
- });
- assert.deepEqual(decision, { action: 'drop_echo' });
- });
- test('fromMe is dropped when forwarding is disabled', () => {
- const decision = classifyOwnerMessageGate({
- fromMe: true,
- fromOwnerEnabled: false,
- recentlySent: makeRecentlySent(),
- allowlistMatches: makeAllowlist('*'),
- messageId: 'M-OWN-2',
- chatId: '6281234567890@s.whatsapp.net',
- });
- assert.deepEqual(decision, { action: 'drop_disabled' });
- });
- test('fromMe is dropped when chatId is not on the allowlist (regression)', () => {
- // This is the bug. Before the fix, an owner reply in a non-allowlisted
- // chat was still forwarded with fromOwner: true, which made the
- // gateway-policy owner-implicit branch create stray handover rows for
- // the non-allowlisted contact.
- const decision = classifyOwnerMessageGate({
- fromMe: true,
- fromOwnerEnabled: true,
- recentlySent: makeRecentlySent(),
- allowlistMatches: makeAllowlist(['6281234567890@s.whatsapp.net']),
- messageId: 'M-OWN-3',
- chatId: '111600547700784@lid',
- });
- assert.deepEqual(decision, { action: 'drop_allowlist' });
- });
- test('fromMe is forwarded as owner when chatId is allowlisted', () => {
- const decision = classifyOwnerMessageGate({
- fromMe: true,
- fromOwnerEnabled: true,
- recentlySent: makeRecentlySent(),
- allowlistMatches: makeAllowlist(['6281234567890@s.whatsapp.net']),
- messageId: 'M-OWN-4',
- chatId: '6281234567890@s.whatsapp.net',
- });
- assert.deepEqual(decision, { action: 'forward_owner' });
- });
- test('open-allowlist (matchesAllowedUser short-circuits true) forwards as owner', () => {
- // matchesAllowedUser returns true on empty allowlist or "*"; the gate
- // must respect that so deployments without an allowlist are unaffected
- // by the new check.
- const decision = classifyOwnerMessageGate({
- fromMe: true,
- fromOwnerEnabled: true,
- recentlySent: makeRecentlySent(),
- allowlistMatches: () => true,
- messageId: 'M-OWN-5',
- chatId: '111600547700784@lid',
- });
- assert.deepEqual(decision, { action: 'forward_owner' });
- });
- test('echo check fires before allowlist check', () => {
- // A bot-API echo whose chatId happens to be off-allowlist should still
- // be dropped as drop_echo, not drop_allowlist, so logging stays
- // honest about the actual reason.
- const decision = classifyOwnerMessageGate({
- fromMe: true,
- fromOwnerEnabled: true,
- recentlySent: makeRecentlySent(['M-ECHO-1']),
- allowlistMatches: makeAllowlist([]),
- messageId: 'M-ECHO-1',
- chatId: '111600547700784@lid',
- });
- assert.deepEqual(decision, { action: 'drop_echo' });
- });
- test('disabled flag fires before allowlist check', () => {
- // Pre-existing deployments with WHATSAPP_FORWARD_OWNER_MESSAGES unset
- // must see drop_disabled regardless of allowlist state, otherwise
- // every fromMe message would log a misleading allowlist_mismatch.
- const decision = classifyOwnerMessageGate({
- fromMe: true,
- fromOwnerEnabled: false,
- recentlySent: makeRecentlySent(),
- allowlistMatches: makeAllowlist([]),
- messageId: 'M-OWN-6',
- chatId: '111600547700784@lid',
- });
- assert.deepEqual(decision, { action: 'drop_disabled' });
- });
|